Chromium Code Reviews

Issue 1056373003: Keep Mac sources that shouldn't been removed for gn builds (Closed)

Created:
5 years, 8 months ago by Jiang Jiang
Modified:
5 years, 8 months ago
Reviewers:
leviw_travelin_and_unemployed, dpranke, Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Keep Mac sources that shouldn't been removed for gn builds To match blink_platform.gyp. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193806

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -4 lines)
M Source/platform/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments

Messages

Total messages: 9 (4 generated)
Jiang Jiang
5 years, 8 months ago (2015-04-15 06:13:17 UTC) #2
Jiang Jiang
5 years, 8 months ago (2015-04-15 10:49:31 UTC) #4
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-15 15:48:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056373003/1
5 years, 8 months ago (2015-04-15 16:19:42 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 17:33:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193806

Powered by Google App Engine