Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1056363003: Revert of Remove NACL_BUILD_ARCH_MAP (Closed)

Created:
5 years, 8 months ago by teravest
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of Remove NACL_BUILD_ARCH_MAP (patchset #1 id:1 of https://codereview.chromium.org/1039253003/) Reason for revert: build_nexe.py may perform cross-compliation with the "--arch flag"; it looks like one of the PNaCl FYI bots builds MIPS nexes on a x86_32 without defining the __mipsel__ flag. I'd prefer to revert instead of hacking around this for MIPS; I'm a bit confused as to why the output from the FYI bot is using pnacl-clang and gcc and don't want to. Original issue's description: > Remove NACL_BUILD_ARCH_MAP. > > This mapping is no longer necessary now that build_config.h provides these definitions. > > The only exception is when NACL_BUILD_ARCH=pnacl should be defined, which build_config.h doesn't have the necessary information to detect. > > BUG=https://code.google.com/p/chromium/issues/detail?id=440012 > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/1e45f86b3f0b78399d853fd187e8a3d515b1a38f TBR=ncbray@chromium.org,jfb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://code.google.com/p/chromium/issues/detail?id=440012 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/9b893060e6f45d52b665cf7160c073eec37edda5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M build/build_nexe.py View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
teravest
Created Revert of Remove NACL_BUILD_ARCH_MAP
5 years, 8 months ago (2015-04-06 15:13:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056363003/1
5 years, 8 months ago (2015-04-06 15:13:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-06 15:13:53 UTC) #4
Nick Bray (chromium)
LGTM
5 years, 8 months ago (2015-04-06 17:28:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056363003/1
5 years, 8 months ago (2015-04-06 17:31:41 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 17:31:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/9b893060e...

Powered by Google App Engine
This is Rietveld 408576698