Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

Issue 1056353003: Derive the SourceAlpha filter input from SourceGraphic (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/graphics/filters/SVGFilterBuilder.h ('k') | Source/platform/graphics/filters/SourceAlpha.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
diff --git a/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp b/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
index 5c3104812fcc423ebac0aab967cda1757de4d8b6..b861321d9555ea7833b840314821a395f3f278d5 100644
--- a/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
+++ b/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
@@ -25,10 +25,11 @@
namespace blink {
-SVGFilterBuilder::SVGFilterBuilder(PassRefPtrWillBeRawPtr<FilterEffect> sourceGraphic, PassRefPtrWillBeRawPtr<FilterEffect> sourceAlpha)
+SVGFilterBuilder::SVGFilterBuilder(PassRefPtrWillBeRawPtr<FilterEffect> prpSourceGraphic)
{
+ RefPtrWillBeRawPtr<FilterEffect> sourceGraphic = prpSourceGraphic;
Stephen White 2015/04/20 17:04:49 Nit: Blink coding style prefers no abbreviations.
fs 2015/04/21 10:29:20 Done.
m_builtinEffects.add(SourceGraphic::effectName(), sourceGraphic);
- m_builtinEffects.add(SourceAlpha::effectName(), sourceAlpha);
+ m_builtinEffects.add(SourceAlpha::effectName(), SourceAlpha::create(sourceGraphic.get()));
addBuiltinEffects();
}
« no previous file with comments | « Source/core/svg/graphics/filters/SVGFilterBuilder.h ('k') | Source/platform/graphics/filters/SourceAlpha.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698