Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1056353003: Derive the SourceAlpha filter input from SourceGraphic (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, Justin Novosad, danakj, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, zoltan1, jbroman, Dominik Röttsches, pdr+graphicswatchlist_chromium.org, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Derive the SourceAlpha filter input from SourceGraphic Let the SourceAlpha FilterEffect wrap a FilterEffect rather than just getting the SourceGraphic reference from the SkiaImageFilterBuilder. This makes the DAG constructed for a url(...) reference within a <filter-function-list> only have a single input - SourceGraphic. Matches Gecko-behavior for 'filter'. BUG=109224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194115

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
A LayoutTests/css3/filters/effect-reference-source-alpha-not-first.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/css3/filters/effect-reference-source-alpha-not-first-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/SourceAlpha.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/SourceAlpha.cpp View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
>BUG=109224 Could perhaps have used a better bug-ref...
5 years, 8 months ago (2015-04-20 16:46:34 UTC) #2
Stephen White
Nice! Thanks for fixing this. LGTM w/nit https://codereview.chromium.org/1056353003/diff/1/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp File Source/core/svg/graphics/filters/SVGFilterBuilder.cpp (right): https://codereview.chromium.org/1056353003/diff/1/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp#newcode30 Source/core/svg/graphics/filters/SVGFilterBuilder.cpp:30: RefPtrWillBeRawPtr<FilterEffect> sourceGraphic ...
5 years, 8 months ago (2015-04-20 17:04:49 UTC) #3
fs
https://codereview.chromium.org/1056353003/diff/1/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp File Source/core/svg/graphics/filters/SVGFilterBuilder.cpp (right): https://codereview.chromium.org/1056353003/diff/1/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp#newcode30 Source/core/svg/graphics/filters/SVGFilterBuilder.cpp:30: RefPtrWillBeRawPtr<FilterEffect> sourceGraphic = prpSourceGraphic; On 2015/04/20 17:04:49, Stephen White ...
5 years, 8 months ago (2015-04-21 10:29:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056353003/20001
5 years, 8 months ago (2015-04-21 11:47:32 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 11:51:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194115

Powered by Google App Engine
This is Rietveld 408576698