PRESUBMIT.py - Issue 105633012: Include order check should work better for files containing uncheckable includes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 105633012: Include order check should work better for files containing uncheckable includes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 5e64d57ed460d8138391209fd5f2161007609034..d81562992613b8513bc6276e3a093cfd5c0397c2 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -666,7 +666,7 @@ def _CheckIncludeOrderInFile(input_api, f, changed_linenums):

for line in contents[line_num:]:

line_num += 1

if uncheckable_includes_pattern.match(line):

- return []

+ continue

if if_pattern.match(line):

scopes.append(current_scope)

current_scope = []

« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »