Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 105633012: Include order check should work better for files containing uncheckable includes (Closed)

Created:
6 years, 11 months ago by kbalazs
Modified:
6 years, 11 months ago
Reviewers:
M-A Ruel, marja
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Include order check should work better for files containing uncheckable includes Currently as soon as we see an uncheckable include (like ipc/*macros.h or windows.h) we stop checking the file. Instead we should just skip that line and continue checking. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kbalazs
6 years, 11 months ago (2014-01-06 21:08:01 UTC) #1
M-A Ruel
Marja wrote this. Once she agrees with this CL, I'll rubberstamp it.
6 years, 11 months ago (2014-01-07 13:59:23 UTC) #2
marja
lgtm, seems reasonable.
6 years, 11 months ago (2014-01-07 17:12:58 UTC) #3
M-A Ruel
On 2014/01/07 17:12:58, marja wrote: > lgtm, seems reasonable. lgtm
6 years, 11 months ago (2014-01-07 17:13:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/105633012/1
6 years, 11 months ago (2014-01-07 19:06:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208622
6 years, 11 months ago (2014-01-07 20:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/105633012/1
6 years, 11 months ago (2014-01-07 20:46:37 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:19:55 UTC) #8
Message was sent while issue was closed.
Change committed as 243427

Powered by Google App Engine
This is Rietveld 408576698