Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1056313004: mac: Weakly link against the CoreBluetooth framework. (attempt #2) (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Weakly link against the CoreBluetooth framework. (attempt #2) The first attempt to land this CL failed because there weas a missing import in device/BUILD.gn. > mac: Weakly link against the CoreBluetooth framework. > > In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously, > it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX > 10.10, the top level CoreBluetooth framework must be weakly linked. > > BUG=463170 > Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8 > Cr-Commit-Position: refs/heads/master@{#326705} BUG=463170 TBR=rsesek@chromium.org, keybuk@chromium.org Committed: https://crrev.com/ceb2fff7aa06959511e021778b11b76704f45429 Cr-Commit-Position: refs/heads/master@{#327065}

Patch Set 1 : Copy of patch set 3. Sending builds to all GN trybots #

Patch Set 2 : Exact copy of patchset #2 id:80001 of https://codereview.chromium.org/1101513003/ #

Patch Set 3 : Fix missing import. #

Patch Set 4 : Rebase against top of tree. #

Patch Set 5 : Only add mac include on macs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M device/BUILD.gn View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056313004/80001
5 years, 8 months ago (2015-04-27 16:48:42 UTC) #2
scheib
FYI you can re-land the 'same' (or with minor diff) patches from the original code ...
5 years, 8 months ago (2015-04-27 17:26:14 UTC) #4
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-27 17:51:01 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 17:52:06 UTC) #6
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ceb2fff7aa06959511e021778b11b76704f45429
Cr-Commit-Position: refs/heads/master@{#327065}

Powered by Google App Engine
This is Rietveld 408576698