Issue 1056253003: When wrapping external textures, clamp the MSAA sample count to max.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056253003: When wrapping external textures, clamp the MSAA sample count to max. (Closed)

Created:
5 years, 8 months ago by Stephen White

Modified:
5 years, 8 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

When wrapping external textures, clamp the MSAA sample count to max. This is the same clamp we do in onCreateTexture() for Skia-native textures. Without this fix, setting to a count higher than the max in Chrome results in a black screen. BUG=skia: Committed: https://skia.googlesource.com/skia/+/94e50100eb747b2dfd659bacc9cf4246f6f20278

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/gpu/gl/GrGLGpu.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056253003/1

5 years, 8 months ago (2015-04-06 16:36:41 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-06 16:43:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/94e50100eb747b2dfd659bacc9cf4246f6f20278

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages