Debug UI for DOM distiller supports distillation and lists articles.

Debug UI for DOM distiller supports distillation and lists articles.

This adds functionality to trigger distillation of web pages from the
debug UI and also lists the current set of articles.

BUG=319881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239168

[nyquist, 2013-12-04 23:52:25]

thakis: PTAL for overview

patch set 1 is the "mechanical move" of the list and destillation related
things. patch set 2 is the cleaned up version.

[Nico, 2013-12-05 00:03:57]

lgtm with minor comments, thanks

https://codereview.chromium.org/105623002/diff/10001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://codereview.chromium.org/105623002/diff/10001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:202: return new
dom_distiller::DomDistillerUi(web_ui, service, "dummy");
Add "//TODO: add real scheme"

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
File components/dom_distiller/webui/resources/about_dom_distiller.js (right):

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
components/dom_distiller/webui/resources/about_dom_distiller.js:18: if
(entries.length > 0) {
Now that the createElement('ul') is gone, this check is no longer needed

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
File components/dom_distiller_strings.grdp (right):

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
components/dom_distiller_strings.grdp:7: <message
name="IDS_DOM_DISTILLER_WEBUI_ENTRY_TITLE" desc="The text to show when
describing the title of the entry.">
Translators look at the desc strings in isolation from other descs as far as I
know. "Title of an entry on the DOM Distiller debug page" might be more
informative (also below)

[nyquist, 2013-12-05 00:24:02]

done

https://codereview.chromium.org/105623002/diff/10001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://codereview.chromium.org/105623002/diff/10001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:202: return new
dom_distiller::DomDistillerUi(web_ui, service, "dummy");
On 2013/12/05 00:03:58, Nico wrote:
> Add "//TODO: add real scheme"

Done.

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
File components/dom_distiller/webui/resources/about_dom_distiller.js (right):

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
components/dom_distiller/webui/resources/about_dom_distiller.js:18: if
(entries.length > 0) {
On 2013/12/05 00:03:58, Nico wrote:
> Now that the createElement('ul') is gone, this check is no longer needed

Done.

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
File components/dom_distiller_strings.grdp (right):

https://codereview.chromium.org/105623002/diff/10001/components/dom_distiller...
components/dom_distiller_strings.grdp:7: <message
name="IDS_DOM_DISTILLER_WEBUI_ENTRY_TITLE" desc="The text to show when
describing the title of the entry.">
On 2013/12/05 00:03:58, Nico wrote:
> Translators look at the desc strings in isolation from other descs as far as I
> know. "Title of an entry on the DOM Distiller debug page" might be more
> informative (also below)

Done.

[commit-bot: I haz the power, 2013-12-05 00:27:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/105623002/30001

[commit-bot: I haz the power, 2013-12-05 00:27:22]

Failed to apply patch for chrome/chrome_browser_ui.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_browser_ui.gypi
  Hunk #1 FAILED at 2599.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/chrome_browser_ui.gypi.rej

Patch:       chrome/chrome_browser_ui.gypi
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index
3d80bc86d6042c5eba81fa5a4dfd2e214a99b0ae..559237381f984e88d0e90e0f5665fbfc04160301
100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -2599,6 +2599,7 @@
             'installer_util',
             '../components/components.gyp:autofill_content_risk_proto',
             '../components/component_strings.gyp:component_strings',
+            '../components/components.gyp:dom_distiller_content',
             '../components/components.gyp:dom_distiller_core',
             '../components/components.gyp:dom_distiller_webui',
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',

[commit-bot: I haz the power, 2013-12-05 00:55:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/105623002/50001

[commit-bot: I haz the power, 2013-12-05 01:37:17]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[blundell, 2013-12-05 10:09:20]

https://codereview.chromium.org/105623002/diff/50001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/105623002/diff/50001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:34:
'../components/components.gyp:dom_distiller_content',
FYI, the reason that you're getting the errors on the iOS bots is that this
dependency should be in the OS!="ios" section. If
https://codereview.chromium.org/100623006/ lands first, you won't need this
dependency anymore though.

[nyquist, 2013-12-05 18:30:28]

https://codereview.chromium.org/105623002/diff/50001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/105623002/diff/50001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:34:
'../components/components.gyp:dom_distiller_content',
On 2013/12/05 10:09:21, blundell wrote:
> FYI, the reason that you're getting the errors on the iOS bots is that this
> dependency should be in the OS!="ios" section. If
> https://codereview.chromium.org/100623006/ lands first, you won't need this
> dependency anymore though.

Yep. Rebased now.

[commit-bot: I haz the power, 2013-12-05 18:32:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/105623002/70001

[commit-bot: I haz the power, 2013-12-05 19:41:00]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, net_unittests, sql_unittests,
ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-12-05 22:28:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/105623002/90001

[commit-bot: I haz the power, 2013-12-06 11:57:17]

Change committed as 239168

[blundell, 2013-12-10 13:52:42]

FYI, I figured out the missing dependencies that the transient iOS build
failures were indicating:

https://codereview.chromium.org/111503003/ (protobuf header)
https://codereview.chromium.org/102073007/ (strings header)