Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: runtime/vm/symbols.h

Issue 1056203002: Eliminate some duplicate symbols in the predefined symbols list (the keyword list already has these… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.h
===================================================================
--- runtime/vm/symbols.h (revision 44890)
+++ runtime/vm/symbols.h (working copy)
@@ -16,7 +16,6 @@
// One-character symbols are added implicitly.
#define PREDEFINED_SYMBOLS_LIST(V) \
- V(Empty, "") \
V(EqualOperator, "==") \
V(GreaterEqualOperator, ">=") \
V(LessEqualOperator, "<=") \
@@ -31,9 +30,7 @@
V(AssignIndexToken, "[]=") \
V(TopLevel, "::") \
V(DefaultLabel, ":L") \
- V(This, "this") \
V(Other, "other") \
- V(Super, "super") \
V(Call, "call") \
V(Current, "current") \
V(MoveNext, "moveNext") \
@@ -92,7 +89,6 @@
V(SavedStackTraceVar, ":saved_stack_trace_var") \
V(ListLiteralElement, "list literal element") \
V(ForInIter, ":for-in-iter") \
- V(Library, "library") \
V(LoadLibrary, "loadLibrary") \
V(_LibraryPrefix, "_LibraryPrefix") \
V(On, "on") \
@@ -129,7 +125,6 @@
V(Class, "Class") \
V(Null, "Null") \
V(Dynamic, "dynamic") \
- V(Void, "void") \
V(UnresolvedClass, "UnresolvedClass") \
V(Type, "_Type") \
V(TypeRef, "_TypeRef") \
@@ -176,8 +171,6 @@
V(_Bigint, "_Bigint") \
V(_Double, "_Double") \
V(Bool, "bool") \
- V(True, "true") \
- V(False, "false") \
V(_List, "_List") \
V(_ListFactory, "_List.") \
V(_GrowableList, "_GrowableList") \
@@ -512,6 +505,14 @@
return *(symbol_handles_[kNullCharId + '~']);
}
+ static const String& Empty() { return *(symbol_handles_[kKwTableStart]); }
+ static const String& False() { return *(symbol_handles_[kFALSEId]); }
+ static const String& Library() { return *(symbol_handles_[kLIBRARYId]); }
+ static const String& Super() { return *(symbol_handles_[kSUPERId]); }
+ static const String& This() { return *(symbol_handles_[kTHISId]); }
+ static const String& True() { return *(symbol_handles_[kTRUEId]); }
+ static const String& Void() { return *(symbol_handles_[kVOIDId]); }
+
// Access methods for symbol handles stored in the vm isolate.
#define DEFINE_SYMBOL_HANDLE_ACCESSOR(symbol, literal) \
static const String& symbol() { return *(symbol_handles_[k##symbol##Id]); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698