Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1056193003: Rename methods to better match new terminology and get rid of json data file. (Closed)

Created:
5 years, 8 months ago by wibling
Modified:
5 years, 8 months ago
Reviewers:
Shams
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/one-hour-codelab.git@server2
Visibility:
Public.

Description

Rename methods to better match new terminology and get rid of json data file. R=shaza@google.com BUG= Committed: https://github.com/dart-lang/one-hour-codelab/commit/5a03ddc6c820eba1d16af7ddb64bc72d99d37fce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -518 lines) Patch
M 2-1-starter/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-1-starter/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-1-starter/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-1-starter/lib/server/piratesapi.dart View 2 chunks +4 lines, -14 lines 0 comments Download
M 2-2-simple/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-2-simple/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-2-simple/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-2-simple/lib/server/piratesapi.dart View 3 chunks +4 lines, -14 lines 0 comments Download
M 2-4-extended/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-4-extended/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-4-extended/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-4-extended/lib/server/piratesapi.dart View 3 chunks +11 lines, -21 lines 0 comments Download
M 2-5-generated/lib/client/piratesapi.dart View 9 chunks +73 lines, -64 lines 0 comments Download
M 2-5-generated/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-5-generated/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-5-generated/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-5-generated/lib/server/piratesapi.dart View 3 chunks +11 lines, -21 lines 0 comments Download
M 2-6-client/lib/client/piratesapi.dart View 9 chunks +73 lines, -64 lines 0 comments Download
M 2-6-client/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-6-client/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-6-client/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-6-client/lib/server/piratesapi.dart View 3 chunks +11 lines, -21 lines 0 comments Download
M 2-6-client/web/piratebadge.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M 2-7-serve/lib/client/piratesapi.dart View 9 chunks +73 lines, -64 lines 0 comments Download
M 2-7-serve/lib/common/messages.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M 2-7-serve/lib/common/utils.dart View 1 chunk +29 lines, -1 line 0 comments Download
D 2-7-serve/lib/server/piratenames.json View 1 chunk +0 lines, -23 lines 0 comments Download
M 2-7-serve/lib/server/piratesapi.dart View 3 chunks +11 lines, -21 lines 0 comments Download
M 2-7-serve/web/piratebadge.dart View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wibling
PTAL
5 years, 8 months ago (2015-04-17 13:31:24 UTC) #1
wibling
5 years, 8 months ago (2015-04-17 14:03:36 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 5a03ddc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698