Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1056183002: Better error messages (Closed)

Created:
5 years, 8 months ago by Leaf
Modified:
5 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-dev-compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better error messages This records the actual point at which type inference fails and uses that to give a better error message. So where before we would say: severe: line 76, column 38 of package:angular2/src/forms/directives.dart: [StaticTypeError] Type check failed: [c.validator, this.validator] (List<dynamic>) is not of type List<Function> c.validator = validators.compose([c.validator, this.validator]); we will now in addition say: because c.validator cannot be typed as Function BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5ebda81983a16422298f00ffefc3b6b366e6de3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M lib/src/checker/rules.dart View 9 chunks +29 lines, -23 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/info.dart View 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
5 years, 8 months ago (2015-04-03 19:38:03 UTC) #2
vsm
lgtm!
5 years, 8 months ago (2015-04-03 19:48:26 UTC) #3
Leaf
5 years, 8 months ago (2015-04-03 19:49:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ebda81983a16422298f00ffefc3b6b366e6de3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698