Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1056153002: Reland 'Require ECDHE for False Start.' (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 'Require ECDHE for False Start.' This is a reland of https://codereview.chromium.org/1057733002. It rolls BoringSSL slightly further than previously to fix a Windows build issue. This adds just enough of an implementation of ECDHE_RSA to tlslite to support it on the server side. It also rolls BoringSSL e2e1326..40acdae to pick up the corresponding BoringSSL change. Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/e2e1326..40acdae BUG=460271 TBR=rsleevi@chromium.org,agl@chromium.org Committed: https://crrev.com/1f77e1a27417e217dfe0bb1d424f19e2272b47c3 Cr-Commit-Position: refs/heads/master@{#323780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+824 lines, -76 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 7 chunks +29 lines, -9 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.cc View 8 chunks +63 lines, -36 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 12 chunks +24 lines, -10 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/tlslite/README.chromium View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/tlslite/patches/ecdhe_rsa.patch View 1 chunk +428 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 9 chunks +44 lines, -1 line 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tlslite/tlslite/messages.py View 4 chunks +16 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 5 chunks +28 lines, -3 lines 0 comments Download
A third_party/tlslite/tlslite/utils/p256.py View 1 chunk +162 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
davidben
(This is identical to the previous one but for DEPS, so it's TBR. I'll CQ ...
5 years, 8 months ago (2015-04-03 17:38:50 UTC) #1
agl
lgtm
5 years, 8 months ago (2015-04-03 17:40:29 UTC) #2
davidben
Build failure reproduced and verified that this fixes it. For some reason, it only affects ...
5 years, 8 months ago (2015-04-03 18:26:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056153002/1
5 years, 8 months ago (2015-04-03 18:26:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 18:35:53 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:39:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f77e1a27417e217dfe0bb1d424f19e2272b47c3
Cr-Commit-Position: refs/heads/master@{#323780}

Powered by Google App Engine
This is Rietveld 408576698