Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1056143002: ash: Use PaintRecorder in CursorWindowDelegate (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, enne (OOO), piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Use PaintRecorder in CursorWindowDelegate Instead of accessing canvas() on the PaintContext directly, go through the PaintRecorder. This will enable us to stop backing the PaintContext with a Canvas for slimming-paint. R=oshima BUG=466426 Committed: https://crrev.com/2c03b15eace1106274f6aa78b87bb1d2e45b1864 Cr-Commit-Position: refs/heads/master@{#323959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ash/display/cursor_window_controller.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
danakj
5 years, 8 months ago (2015-04-03 17:30:13 UTC) #1
danakj
This replaces https://codereview.chromium.org/1021823002/, but depends on https://codereview.chromium.org/1053143002/
5 years, 8 months ago (2015-04-03 17:30:26 UTC) #2
oshima
lgtm
5 years, 8 months ago (2015-04-03 17:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056143002/1
5 years, 8 months ago (2015-04-04 01:26:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/24552)
5 years, 8 months ago (2015-04-04 02:07:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056143002/1
5 years, 8 months ago (2015-04-06 21:16:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 22:06:05 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 22:07:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c03b15eace1106274f6aa78b87bb1d2e45b1864
Cr-Commit-Position: refs/heads/master@{#323959}

Powered by Google App Engine
This is Rietveld 408576698