Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1056133009: Fix the validation of the keyframe requests. (Closed)

Created:
5 years, 8 months ago by Owen Lin
Modified:
5 years, 8 months ago
Reviewers:
wuchengli, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the validation of the key frame requests. 1. Initialize |next_keyframe_at_| to 0, so that the expected sequence will be i * |keyframe_period_|. 2. Update |next_keyframe_at_|, when a key frame is arrived at the requested window. Other key frames should be ignored. BUG=470775 TEST=Run the binary on Samus and Peach-Pit Committed: https://crrev.com/7ae211fe61dad3e0fc129db8667b1aa922f3fb7b Cr-Commit-Position: refs/heads/master@{#326724}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Owen Lin
PTAL.
5 years, 8 months ago (2015-04-22 07:19:36 UTC) #2
Pawel Osciak
On 2015/04/22 07:19:36, Owen Lin wrote: > PTAL. This is unfortunately going back to the ...
5 years, 8 months ago (2015-04-22 08:22:13 UTC) #3
Owen Lin
On 2015/04/22 08:22:13, Pawel Osciak wrote: > On 2015/04/22 07:19:36, Owen Lin wrote: > > ...
5 years, 8 months ago (2015-04-23 06:30:48 UTC) #4
Pawel Osciak
lgtm, but please update the CL message
5 years, 8 months ago (2015-04-24 01:20:07 UTC) #5
Owen Lin
On 2015/04/24 01:20:07, Pawel Osciak wrote: > lgtm, but please update the CL message Done. ...
5 years, 8 months ago (2015-04-24 02:07:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056133009/20001
5 years, 8 months ago (2015-04-24 02:07:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 02:35:37 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 02:37:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ae211fe61dad3e0fc129db8667b1aa922f3fb7b
Cr-Commit-Position: refs/heads/master@{#326724}

Powered by Google App Engine
This is Rietveld 408576698