Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1056133003: Move page/actions to internal/actions. (Closed)

Created:
5 years, 8 months ago by aiolos (Not reviewing)
Modified:
5 years, 8 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move page/actions to internal/actions. BUG=473414 Committed: https://crrev.com/dc71a552a2653799899c3e9a4aa76630bd2bd98c Cr-Commit-Position: refs/heads/master@{#323845}

Patch Set 1 #

Patch Set 2 : Forgot to add internal/__init__.py to the commit. :( #

Patch Set 3 : Add copyright header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2629 lines) Patch
M tools/perf/page_sets/garbage_collection_cases.py View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/drag.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/drag.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/drag_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/gesture_common.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/javascript_click.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/loop.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/loop.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/loop_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/media_action.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/media_action.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/mouse_click.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/mouse_click.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/navigate.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/navigate_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/page_action.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/page_action_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/pinch.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/pinch.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/pinch_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/play.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/play.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/play_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/repaint_continuously.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/scroll.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/scroll.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/scroll_bounce.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/scroll_bounce.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/scroll_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/seek.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/seek.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/seek_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/swipe.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/swipe.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/tap.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/actions/tap.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/actions/wait.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/action_runner.py View 1 chunk +14 lines, -14 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +0 lines, -250 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag.js View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag.py View 1 chunk +0 lines, -104 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/gesture_common.js View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/javascript_click.py View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/loop.js View 1 chunk +0 lines, -53 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/loop.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/loop_unittest.py View 1 chunk +0 lines, -52 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/media_action.js View 1 chunk +0 lines, -59 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/media_action.py View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/mouse_click.js View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/mouse_click.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/mouse_click_unittest.py View 1 chunk +0 lines, -52 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/navigate.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/navigate_unittest.py View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/page_action.py View 1 chunk +0 lines, -133 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/page_action_unittest.py View 1 chunk +0 lines, -82 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/pinch.js View 1 chunk +0 lines, -75 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/pinch.py View 1 chunk +0 lines, -86 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/pinch_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/play.js View 1 chunk +0 lines, -35 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/play.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/play_unittest.py View 1 chunk +0 lines, -110 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/repaint_continuously.py View 1 chunk +0 lines, -35 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/scroll.js View 1 chunk +0 lines, -119 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/scroll.py View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/scroll_bounce.js View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/scroll_bounce.py View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/scroll_unittest.py View 1 chunk +0 lines, -89 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/seek.js View 1 chunk +0 lines, -57 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/seek.py View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/seek_unittest.py View 1 chunk +0 lines, -66 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/swipe.js View 1 chunk +0 lines, -75 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/swipe.py View 1 chunk +0 lines, -78 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/tap.js View 1 chunk +0 lines, -73 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/tap.py View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/wait.py View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
aiolos (Not reviewing)
5 years, 8 months ago (2015-04-03 19:58:19 UTC) #2
nednguyen
lgtm
5 years, 8 months ago (2015-04-03 20:00:41 UTC) #3
dtu
lgtm
5 years, 8 months ago (2015-04-03 21:11:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056133003/60001
5 years, 8 months ago (2015-04-03 22:27:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056133003/60001
5 years, 8 months ago (2015-04-03 22:37:51 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-04-03 23:25:36 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 23:26:27 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc71a552a2653799899c3e9a4aa76630bd2bd98c
Cr-Commit-Position: refs/heads/master@{#323845}

Powered by Google App Engine
This is Rietveld 408576698