Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/ui/toolbar/toolbar_model.h

Issue 105613002: Remove unused parameter to ToolbarModel::GetText. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding an Android call I missed earlier. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_model.h
diff --git a/chrome/browser/ui/toolbar/toolbar_model.h b/chrome/browser/ui/toolbar/toolbar_model.h
index 3b1c28d94d498db981e63ddea9d58570631a00b5..949764f03b11229a50c94d307baf7d15bcb51ee5 100644
--- a/chrome/browser/ui/toolbar/toolbar_model.h
+++ b/chrome/browser/ui/toolbar/toolbar_model.h
@@ -35,10 +35,9 @@ class ToolbarModel {
// for display to the user:
// - Some characters may be unescaped.
// - The scheme and/or trailing slash may be dropped.
- // - if |allow_search_term_replacement| is true, the query will be extracted
- // from search URLs for the user's default search engine and will be
- // displayed in place of the URL.
- virtual string16 GetText(bool allow_search_term_replacement) const = 0;
+ // - If the current page's URL is a search URL for the user's default search
+ // engine, the query will be extracted and returned.
Peter Kasting 2013/12/05 07:06:23 Nit: returned -> displayed in place of the URL
Justin Donnelly 2013/12/05 15:33:03 But this method doesn't actually display the URL,
Peter Kasting 2013/12/05 19:45:36 That's fair. Since the context here is "Returns t
Justin Donnelly 2013/12/05 21:10:06 Sounds good to me. Unfortunately, I seem to have
+ virtual string16 GetText() const = 0;
// Some search URLs bundle a special "corpus" param that we can extract and
// display next to users' search terms in cases where we'd show the search
@@ -50,7 +49,7 @@ class ToolbarModel {
// Returns the URL of the current navigation entry.
virtual GURL GetURL() const = 0;
- // Returns true if a call to GetText(true) would successfully replace the URL
+ // Returns true if a call to GetText() would successfully replace the URL
// with search terms. If |ignore_editing| is true, the result reflects the
// underlying state of the page without regard to any user edits that may be
// in progress in the omnibox.

Powered by Google App Engine
This is Rietveld 408576698