Remove unused parameter to ToolbarModel::GetText.

Remove unused parameter to ToolbarModel::GetText.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239031

[Peter Kasting, 2013-12-05 07:06:23]

LGTM

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model.h (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model.h:39: //     engine, the query will be
extracted and returned.
Nit: returned -> displayed in place of the URL

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model_unittest.cc (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model_unittest.cc:220:
test_item.expected_replace_text_inactive,
Nit: Don't rewrap these calls you've touched to separate args out onto distinct
lines where they weren't before (several places)

[Justin Donnelly, 2013-12-05 15:33:02]

Thanks for the quick review.  Would you mind committing this for me?

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model.h (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model.h:39: //     engine, the query will be
extracted and returned.
On 2013/12/05 07:06:23, Peter Kasting wrote:
> Nit: returned -> displayed in place of the URL

But this method doesn't actually display the URL, it returns a string.

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model_unittest.cc (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model_unittest.cc:220:
test_item.expected_replace_text_inactive,
On 2013/12/05 07:06:23, Peter Kasting wrote:
> Nit: Don't rewrap these calls you've touched to separate args out onto
distinct
> lines where they weren't before (several places)

Done.  I thought the style guide specified the behavior I was using but I can't
find that now.  Must have been the guide for another language.

[commit-bot: I haz the power, 2013-12-05 15:40:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/105613002/40001

[Peter Kasting, 2013-12-05 19:45:36]

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model.h (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model.h:39: //     engine, the query will be
extracted and returned.
On 2013/12/05 15:33:03, Justin Donnelly wrote:
> On 2013/12/05 07:06:23, Peter Kasting wrote:
> > Nit: returned -> displayed in place of the URL
> 
> But this method doesn't actually display the URL, it returns a string.

That's fair.  Since the context here is "Returns the text for the current page's
URL...formatted for display to the user", I think it's clearer if we say
outright that we're ultimately going to be displaying a query instead of the URL
that the initial sentence describes.  So how about this: "...extracted and
returned for display instead of the URL."

[commit-bot: I haz the power, 2013-12-05 20:43:48]

Change committed as 239031

[Justin Donnelly, 2013-12-05 21:10:06]

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model.h (right):

https://codereview.chromium.org/105613002/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model.h:39: //     engine, the query will be
extracted and returned.
On 2013/12/05 19:45:36, Peter Kasting wrote:
> On 2013/12/05 15:33:03, Justin Donnelly wrote:
> > On 2013/12/05 07:06:23, Peter Kasting wrote:
> > > Nit: returned -> displayed in place of the URL
> > 
> > But this method doesn't actually display the URL, it returns a string.
> 
> That's fair.  Since the context here is "Returns the text for the current
page's
> URL...formatted for display to the user", I think it's clearer if we say
> outright that we're ultimately going to be displaying a query instead of the
URL
> that the initial sentence describes.  So how about this: "...extracted and
> returned for display instead of the URL."

Sounds good to me.

Unfortunately, I seem to have inadvertently committed this change as-is. 
Apparently I have commit access.  I didn't realize that or the fact that
checking the box would send it to the commit queue without further action.

I can rewrite the comment in my next change unless you'd prefer I revert this
one to update the comment.

[Peter Kasting, 2013-12-05 21:55:29]

On 2013/12/05 21:10:06, Justin Donnelly wrote:
> I can rewrite the comment in my next change unless you'd prefer I revert this
> one to update the comment.

Rewriting in the next change -- or just not rewriting at all, if you aren't
touching anything further -- is fine.