Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 1056113004: android_webview: stop leaking Contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2311
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/ResourcesContextWrapperFactory.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
index 5927d91a00c407e950c700e7ecc5692f33377c3d..8316073f1e5b103c7452b0c70b78a95e47a0614c 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
@@ -78,6 +78,7 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
private WebStorageAdapter mWebStorage;
private WebViewDatabaseAdapter mWebViewDatabase;
private AwDevToolsServer mDevToolsServer;
+ private Context mWrappedAppContext;
private ArrayList<WeakReference<WebViewChromium>> mWebViewsToStart =
new ArrayList<WeakReference<WebViewChromium>>();
@@ -290,7 +291,11 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
}
private Context getWrappedCurrentApplicationContext() {
- return ResourcesContextWrapperFactory.get(mWebViewDelegate.getApplication());
+ if (mWrappedAppContext == null) {
+ mWrappedAppContext = ResourcesContextWrapperFactory.get(
+ mWebViewDelegate.getApplication());
+ }
+ return mWrappedAppContext;
}
AwBrowserContext getBrowserContext() {
« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/ResourcesContextWrapperFactory.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698