EXC_CRASH should never be wrapped in another EXC_CRASH

snapshot/mac/exception_snapshot_mac.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 48 matching lines @@
     codes_.push_back(code[code_index]);
   }
 
   exception_ = exception;
   mach_exception_code_t exception_code_0 = code[0];
 
   if (exception_ == EXC_CRASH) {
     exception_ = ExcCrashRecoverOriginalException(
         exception_code_0, &exception_code_0, nullptr);
 
-    if (exception_ == EXC_RESOURCE || exception_ == EXC_GUARD) {
-      // These are software exceptions that are never mapped to EXC_CRASH. The
-      // only time EXC_CRASH is generated is for processes exiting due to an
-      // unhandled core-generating signal or being killed by SIGKILL for
-      // code-signing reasons. Neither of these applies to EXC_RESOURCE or
-      // EXC_GUARD. See 10.10 xnu-2782.1.97/bsd/kern/kern_exit.c
-      // proc_prepareexit().
+    if (exception_ == EXC_CRASH ||
+        exception_ == EXC_RESOURCE ||
+        exception_ == EXC_GUARD) {
+      // EXC_CRASH should never be wrapped in another EXC_CRASH.
       //
-      // Receiving these exception types wrapped in EXC_CRASH would lose
-      // information because their code[0] uses all 64 bits (see below) and the
-      // code[0] recovered from EXC_CRASH only contains 20 significant bits.
+      // EXC_RESOURCE and EXC_GUARD are software exceptions that are never
+      // wrapped in EXC_CRASH. The only time EXC_CRASH is generated is for
+      // processes exiting due to an unhandled core-generating signal or being
+      // killed by SIGKILL for code-signing reasons. Neither of these applies to
+      // EXC_RESOURCE or EXC_GUARD. See 10.10 xnu-2782.1.97/bsd/kern/kern_exit.c
+      // proc_prepareexit(). Receiving these exception types wrapped in
+      // EXC_CRASH would lose information because their code[0] uses all 64 bits
+      // (see below) and the code[0] recovered from EXC_CRASH only contains 20
+      // significant bits.
       LOG(WARNING) << base::StringPrintf(
           "exception %s invalid in EXC_CRASH",
           ExceptionToString(exception_, kUseFullName | kUnknownIsNumeric)
               .c_str());
     }
   }
 
   // The operations that follow put exception_code_0 (a mach_exception_code_t,
   // a typedef for int64_t) into exception_code_0_ (a uint32_t). The range
   // checks and bit shifts involved need the same signedness on both sides to
@@ skipping 151 matching lines @@
   return exception_address_;
 }
 
 const std::vector<uint64_t>& ExceptionSnapshotMac::Codes() const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
   return codes_;
 }
 
 }  // namespace internal
 }  // namespace crashpad