Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1056073003: DevTools: introduce RecordEnumeratedHistogram method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | content/browser/bad_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 03c3c97ae391af45b3c3c767c4f90f82e9308181..50f8b048380fbd8eeb5c309bba9c544a47a189a9 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -749,6 +749,24 @@ void DevToolsUIBindings::RecordActionUMA(const std::string& name, int action) {
UMA_HISTOGRAM_ENUMERATION(name, action, kDevToolsPanelShownBoundary);
}
+void DevToolsUIBindings::RecordEnumeratedHistogram(const std::string& name,
+ int sample,
+ int boundary_value) {
+ if (!(boundary_value >= 0 && boundary_value < 100 && sample >= 0 &&
+ sample < boundary_value)) {
+ frontend_host_->BadMessageRecieved();
+ return;
+ }
+ // Each histogram name must follow a different code path in
+ // order to UMA_HISTOGRAM_ENUMERATION work correctly.
+ if (name == kDevToolsActionTakenHistogram)
+ UMA_HISTOGRAM_ENUMERATION(name, sample, boundary_value);
+ else if (name == kDevToolsPanelShownHistogram)
+ UMA_HISTOGRAM_ENUMERATION(name, sample, boundary_value);
+ else
+ frontend_host_->BadMessageRecieved();
+}
+
void DevToolsUIBindings::SendJsonRequest(const DispatchCallback& callback,
const std::string& browser_id,
const std::string& url) {
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.h ('k') | content/browser/bad_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698