DevTools: introduce RecordEnumeratedHistogram method.

chrome/browser/devtools/devtools_ui_bindings.cc

Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 03c3c97ae391af45b3c3c767c4f90f82e9308181..064d756443beb43f82c38edc0fd312b77a68e9b5 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -749,6 +749,22 @@ void DevToolsUIBindings::RecordActionUMA(const std::string& name, int action) {
     UMA_HISTOGRAM_ENUMERATION(name, action, kDevToolsPanelShownBoundary);
 }
 
+void DevToolsUIBindings::RecordEnumeratedHistogram(const std::string& name,
+                                                   int sample,
+                                                   int boundary_value) {
+  if (!(boundary_value >= 0 && boundary_value < 100 && sample >= 0 &&
+      sample < boundary_value)) {

[Ilya Sherman, 2015/04/07 23:11:25]

nit: Please indent this line two more spaces.

[lushnikov, 2015/04/07 23:21:43]

Done.

+    frontend_host_->BadMessageRecieved();
+    return;
+  }
+  if (name == kDevToolsActionTakenHistogram)
+    UMA_HISTOGRAM_ENUMERATION(name, sample, boundary_value);
+  else if (name == kDevToolsPanelShownHistogram)
+    UMA_HISTOGRAM_ENUMERATION(name, sample, boundary_value);

[Ilya Sherman, 2015/04/07 23:11:25]

Optional nit: It might be worth documenting why the code is written this way, so
that somebody doesn't come along later and introduce bugs by trying to apply a
natural-looking cleanup.

[lushnikov, 2015/04/07 23:21:43]

Done.

+  else
+    frontend_host_->BadMessageRecieved();
+}
+
 void DevToolsUIBindings::SendJsonRequest(const DispatchCallback& callback,
                                          const std::string& browser_id,
                                          const std::string& url) {