Fix mips build error 'undefined reference to dlopen'

Fix mips build error 'undefined reference to dlopen'

BUG=473473
TBR=thakis@chromium.org

Committed: https://crrev.com/89311d3481dc434284972239982a426f8e2154e9
Cr-Commit-Position: refs/heads/master@{#323734}

[Xianzhu, 2015-04-03 00:57:02]

wangxianzhu@chromium.org changed reviewers:
+ carlosk@chromium.org, hablich@chromium.org, jkummerow@chromium.org,
machenbach@chromium.org

[carlosk, 2015-04-03 11:08:09]

carlosk@chromium.org changed reviewers:
+ jochen@chromium.org

[carlosk, 2015-04-03 11:08:09]

jochen@chromium.org: PTAL

Adding an owner for this review.

[pasko, 2015-04-03 11:12:23]

pasko@chromium.org changed reviewers:
+ thakis@chromium.org
- hablich@chromium.org, jkummerow@chromium.org, jochen@chromium.org,
machenbach@chromium.org

[pasko, 2015-04-03 11:19:32]

looks trivial and fixes a downstream bot, so I think TBR is justifiable in this
case, doing that ..

[pasko, 2015-04-03 11:19:37]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2015-04-03 11:19:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056043002/1

[commit-bot: I haz the power, 2015-04-03 12:36:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-03 20:37:25]

Patchset 1 (id:??) landed as
https://crrev.com/89311d3481dc434284972239982a426f8e2154e9
Cr-Commit-Position: refs/heads/master@{#323734}

[Nico, 2015-04-04 20:58:46]

not lgtm

Targets that need dl should list it, like so:
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...

It shouldn't be globally added everywhere.

(owners TBR for stuff like this _is_ ok, but only if you have an lg from a
non-owner)

[Xianzhu, 2015-04-06 16:09:49]

On 2015/04/04 20:58:46, Nico (again away until Monday) wrote:
> not lgtm
> 
> Targets that need dl should list it, like so:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...
> 
> It shouldn't be globally added everywhere.
> 
> (owners TBR for stuff like this _is_ ok, but only if you have an lg from a
> non-owner)

Sorry but we have to keep this CL for a while until the change of v8 fixing the
root cause rolls in.

[Nico, 2015-04-06 16:11:02]

On Mon, Apr 6, 2015 at 9:09 AM, <wangxianzhu@chromium.org> wrote:

> On 2015/04/04 20:58:46, Nico (again away until Monday) wrote:
>
>> not lgtm
>>
>
>  Targets that need dl should list it, like so:
>>
>
> https://code.google.com/p/chromium/codesearch#chromium/
> src/media/media.gyp&q=ldl%5C
>
>  It shouldn't be globally added everywhere.
>>
>
>  (owners TBR for stuff like this _is_ ok, but only if you have an lg from a
>> non-owner)
>>
>
> Sorry but we have to keep this CL for a while until the change of v8
> fixing the
> root cause rolls in.
>

Is there a bug for that? Where's the upstream fix?



>
> https://codereview.chromium.org/1056043002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Xianzhu, 2015-04-06 16:18:43]

On 2015/04/06 16:11:02, Nico (again away until Monday) wrote:
> On Mon, Apr 6, 2015 at 9:09 AM, <mailto:wangxianzhu@chromium.org> wrote:
> 
> > On 2015/04/04 20:58:46, Nico (again away until Monday) wrote:
> >
> >> not lgtm
> >>
> >
> >  Targets that need dl should list it, like so:
> >>
> >
> > https://code.google.com/p/chromium/codesearch#chromium/
> > src/media/media.gyp&q=ldl%5C
> >
> >  It shouldn't be globally added everywhere.
> >>
> >
> >  (owners TBR for stuff like this _is_ ok, but only if you have an lg from a
> >> non-owner)
> >>
> >
> > Sorry but we have to keep this CL for a while until the change of v8
> > fixing the
> > root cause rolls in.
> >
> 
> Is there a bug for that? Where's the upstream fix?
> 

I've reopened crbug.com/473473 and assigned to hablich@chromium.org.

[pasko-google - do not use, 2015-04-07 08:47:29]

On 2015/04/04 20:58:46, Nico wrote:
> not lgtm
> 
> Targets that need dl should list it, like so:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...
> 
> It shouldn't be globally added everywhere.
> 
> (owners TBR for stuff like this _is_ ok, but only if you have an lg from a
> non-owner)

oops, sorry, I did not know about this rule. If I knew, I would have lg-tm-ed.

[pasko-google - do not use, 2015-04-07 08:52:16]

On 2015/04/04 20:58:46, Nico wrote:
> not lgtm
> 
> Targets that need dl should list it, like so:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...
> 
> It shouldn't be globally added everywhere.

this is the first time I see 'link_settings->libraries' in GYP. Sounds like a
much cleaner way than modifying ldfags for everyone. Is it always preferable to
do this way when possible?

[Xianzhu, 2015-04-07 16:10:09]

On 2015/04/07 08:52:16, pasko-google - do not use wrote:
> On 2015/04/04 20:58:46, Nico wrote:
> > not lgtm
> > 
> > Targets that need dl should list it, like so:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...
> > 
> > It shouldn't be globally added everywhere.
> 
> this is the first time I see 'link_settings->libraries' in GYP. Sounds like a
> much cleaner way than modifying ldfags for everyone. Is it always preferable
to
> do this way when possible?

According to crbug.com/473473, the failure seems to be caused by a temporary v8
rollback to a older revision and we had had the failure for a long time before.
Hopefully the failure will be fixed by the next v8 roll and I'll revert this
change after the roll.

[Nico, 2015-04-07 16:49:08]

On 2015/04/07 08:52:16, pasko-google - do not use wrote:
> On 2015/04/04 20:58:46, Nico wrote:
> > not lgtm
> > 
> > Targets that need dl should list it, like so:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=...
> > 
> > It shouldn't be globally added everywhere.
> 
> this is the first time I see 'link_settings->libraries' in GYP. Sounds like a
> much cleaner way than modifying ldfags for everyone. Is it always preferable
to
> do this way when possible?

For libraries, yes. For other flags, probably "it depends".

[Michael Achenbach, 2015-04-08 07:14:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1066363002/ by machenbach@chromium.org.

The reason for reverting is: Speculative revert. The newest v8 roll might fix
the problem..

[pasko, 2015-04-08 09:26:58]

On 2015/04/08 07:14:32, Michael Achenbach wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1066363002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Speculative revert. The newest v8 roll might fix
> the problem..

In situations like these I would prefer if developers tested the fix on the
configuration they are targeting _before_ making a commit. With GOMA it should
be fast, 10x faster than commit and revert, and less churn for others.