chrome/renderer/chrome_content_renderer_client.cc - Issue 10560022: Browser Plugin: New Implementation (Browser Side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10560022: Browser Plugin: New Implementation (Browser Side) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added browser test + Fixed a silly initial loading bug :-) Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index fff4b27f4d75f9f3a0daf311cb995a570ae909f9..47fb119fbb22a839e36dc6c454876c6befeaa90a 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -316,9 +316,10 @@ bool ChromeContentRendererClient::OverrideCreatePlugin(

std::string actual_mime_type;

std::string orig_mime_type = params.mimeType.utf8();

- if (orig_mime_type == content::kBrowserPluginMimeType &&

- extensions::ExtensionHelper::Get(render_view)->view_type() ==

- VIEW_TYPE_APP_SHELL)

+ if (orig_mime_type == content::kBrowserPluginNewMimeType ||

+ ((orig_mime_type == content::kBrowserPluginMimeType) &&

+ extensions::ExtensionHelper::Get(render_view)->view_type() ==

+ VIEW_TYPE_APP_SHELL))

Charlie Reis 2012/08/13 17:50:14 nit: This if needs braces because the condition do

return false;

render_view->Send(new ChromeViewHostMsg_GetPluginInfo(