Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1055973002: Update Checkstyle library from 6.1 to 6.5 (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Checkstyle library from 6.1 to 6.5 Relevant changes: - New allowSingleLineStatement property for NeedBraces check to allow one-line statements. - New option to Indentation to avoid C style. See full release notes here: http://checkstyle.sourceforge.net/releasenotes.html BUG=None R=newt@chromium.org Committed: https://crrev.com/ca43dfb7b9f5209ef5d5912522f015d4d617012b Cr-Commit-Position: refs/heads/master@{#323564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/checkstyle/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/checkstyle/checkstyle-6.1-all.jar View Binary file 0 comments Download
A + third_party/checkstyle/checkstyle-6.5-all.jar View Binary file 0 comments Download
M tools/android/checkstyle/checkstyle.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-02 20:51:33 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-02 21:01:49 UTC) #3
aurimas (slooooooooow)
Committed patchset #1 (id:1) to pending queue manually as 9fa1d2f8567fe9c838b4bbccd22aff24f9720f8c (presubmit successful).
5 years, 8 months ago (2015-04-02 21:25:00 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:29:08 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca43dfb7b9f5209ef5d5912522f015d4d617012b
Cr-Commit-Position: refs/heads/master@{#323564}

Powered by Google App Engine
This is Rietveld 408576698