chrome/browser/extensions/extension_tabs_apitest.cc - Issue 1055933009: Validate windows.create API's state input parameter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 1055933009: Validate windows.create API's state input parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use switch and tweak test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/tabs/tabs_api.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

7 #include "base/prefs/pref_service.h"	7 #include "base/prefs/pref_service.h"

8 #include "chrome/browser/prefs/incognito_mode_prefs.h"	8 #include "chrome/browser/prefs/incognito_mode_prefs.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

(...skipping 236 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
247	247

248 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) {	248 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) {

249 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))	249 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))

250 << message_;	250 << message_;

251 }	251 }

252 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {	252 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {

253 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))	253 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

254 << message_;	254 << message_;

255 }	255 }

256	256

257 // Adding a new test? Awesome. But API tests are the old hotness. The	257 // Adding a new test? Awesome. But API tests are the old hotness. The new

258 // new hotness is extension_test_utils. See tabs_test.cc for an example.	258 // hotness is extension_function_test_utils. See tabs_test.cc for an example.

259 // We are trying to phase out many uses of API tests as they tend to be flaky.	259 // We are trying to phase out many uses of API tests as they tend to be flaky.

OLD	NEW