Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1055933008: Remove hclam from OWNERS files. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
jam, miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, hclam+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, mikhal+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ajwong
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove hclam from OWNERS files. hclam is not actively working on the project anymore BUG=None Committed: https://crrev.com/6ed6542be16dbe9280d0346ced4ad7d868e2afaa Cr-Commit-Position: refs/heads/master@{#325333}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Miu's change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/service_process/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
ncarter (slow)
hclam, please approve if you will
5 years, 8 months ago (2015-04-15 17:58:09 UTC) #1
miu
https://codereview.chromium.org/1055933008/diff/1/content/browser/renderer_host/OWNERS File content/browser/renderer_host/OWNERS (left): https://codereview.chromium.org/1055933008/diff/1/content/browser/renderer_host/OWNERS#oldcode14 content/browser/renderer_host/OWNERS:14: per-file compositing_iosurface*=miu@chromium.org Feel free to delete all "compositing_iosurface*" lines ...
5 years, 8 months ago (2015-04-15 19:24:13 UTC) #4
ncarter (slow)
https://codereview.chromium.org/1055933008/diff/1/content/browser/renderer_host/OWNERS File content/browser/renderer_host/OWNERS (left): https://codereview.chromium.org/1055933008/diff/1/content/browser/renderer_host/OWNERS#oldcode14 content/browser/renderer_host/OWNERS:14: per-file compositing_iosurface*=miu@chromium.org On 2015/04/15 19:24:13, miu wrote: > Feel ...
5 years, 8 months ago (2015-04-15 19:54:36 UTC) #5
ncarter (slow)
jam: please review
5 years, 8 months ago (2015-04-15 19:55:00 UTC) #7
jam
lgtm
5 years, 8 months ago (2015-04-15 20:06:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055933008/20001
5 years, 8 months ago (2015-04-15 21:30:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/43184) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-15 21:36:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055933008/20001
5 years, 8 months ago (2015-04-15 22:22:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 23:05:36 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:06:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ed6542be16dbe9280d0346ced4ad7d868e2afaa
Cr-Commit-Position: refs/heads/master@{#325333}

Powered by Google App Engine
This is Rietveld 408576698