Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1055933006: Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information. (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
Jeremy Klein, michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information. BUG=477154 Committed: https://crrev.com/eb48d65705e44b80d1d7a3b4f21c567802c102bb Cr-Commit-Position: refs/heads/master@{#325309}

Patch Set 1 #

Patch Set 2 : Used relative path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -29 lines) Patch
D chrome/browser/resources/settings/a11y_page/a11y_page.css View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/a11y_page/a11y_page_style.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-15 00:33:13 UTC) #2
Jeremy Klein
lgtm Do we really need *all* of our styles like this or just the ones ...
5 years, 8 months ago (2015-04-15 00:38:45 UTC) #4
Kyle Horimoto
On 2015/04/15 00:38:45, Jeremy Klein wrote: > lgtm > > Do we really need *all* ...
5 years, 8 months ago (2015-04-15 00:52:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055933006/20001
5 years, 8 months ago (2015-04-15 19:07:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 21:23:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:24:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb48d65705e44b80d1d7a3b4f21c567802c102bb
Cr-Commit-Position: refs/heads/master@{#325309}

Powered by Google App Engine
This is Rietveld 408576698