Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1055933003: views: Don't need to anti-alias clip a rect. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, James Su, enne (OOO), piman, pkotwicz, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Don't need to anti-alias clip a rect. OmniboxPopupContentsView used to be clipped by a rounded rect, so it used a ClipPath and anti-aliased the clip for the corners. Now it is just a rectangle, so the anti-aliasing is pointless and potentially adds overhead. R=sky BUG=466426 Committed: https://crrev.com/e7c301c0c202e4599102f537b48c4f4288ed468c Cr-Commit-Position: refs/heads/master@{#323931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danakj
The anti-aliased clip was added in https://chromiumcodereview.appspot.com/10175001/diff/15002/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc?context=&column_width=80&tab_spaces=8 At the time MakeContentsPath was used to make ...
5 years, 8 months ago (2015-04-06 18:10:23 UTC) #1
danakj
+pkasting
5 years, 8 months ago (2015-04-06 18:11:21 UTC) #3
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-06 19:19:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055933003/1
5 years, 8 months ago (2015-04-06 19:20:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 19:25:23 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 19:26:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7c301c0c202e4599102f537b48c4f4288ed468c
Cr-Commit-Position: refs/heads/master@{#323931}

Powered by Google App Engine
This is Rietveld 408576698