lib/src/codegen/js_codegen.dart - Issue 1055923002: Don't call dinvoke on Object methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1055923002: Don't call dinvoke on Object methods (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: modify test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index d1cd2a15ac8f67b9e600fa1083e731704f33118a..b2fa4b4155142af88cc3233888a9776d14c89e0f 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -1733,7 +1733,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {

/// Shared code for [PrefixedIdentifier] and [PropertyAccess].

_visitGet(Expression target, SimpleIdentifier name) {

- if (rules.isDynamicTarget(target)) {

+ if (rules.isDynamicGet(target, name.name)) {

return js.call(

'dart.dload(#, #)', [_visit(target), js.string(name.name, "'")]);

} else {