Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: lib/runtime/dart/convert.js

Issue 1055923002: Don't call dinvoke on Object methods (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: modify test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 var convert; 1 var convert;
2 (function(exports) { 2 (function(exports) {
3 'use strict'; 3 'use strict';
4 let ASCII = new AsciiCodec(); 4 let ASCII = new AsciiCodec();
5 let _ASCII_MASK = 127; 5 let _ASCII_MASK = 127;
6 let _allowInvalid = Symbol('_allowInvalid'); 6 let _allowInvalid = Symbol('_allowInvalid');
7 let _nameToEncoding = Symbol('_nameToEncoding'); 7 let _nameToEncoding = Symbol('_nameToEncoding');
8 let Codec$ = dart.generic(function(S, T) { 8 let Codec$ = dart.generic(function(S, T) {
9 class Codec extends core.Object { 9 class Codec extends core.Object {
10 Codec() { 10 Codec() {
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 } 24 }
25 return Codec; 25 return Codec;
26 }); 26 });
27 let Codec = Codec$(dart.dynamic, dart.dynamic); 27 let Codec = Codec$(dart.dynamic, dart.dynamic);
28 class Encoding extends Codec$(core.String, core.List$(core.int)) { 28 class Encoding extends Codec$(core.String, core.List$(core.int)) {
29 Encoding() { 29 Encoding() {
30 super.Codec(); 30 super.Codec();
31 } 31 }
32 decodeStream(byteStream) { 32 decodeStream(byteStream) {
33 return dart.as(byteStream.transform(dart.as(this.decoder, async.StreamTran sformer$(core.List$(core.int), dynamic))).fold(new core.StringBuffer(), (buffer, string) => dart.dinvoke(buffer, 'write', string), buffer).then((buffer) => dart .dinvoke(buffer, 'toString')), async.Future$(core.String)); 33 return dart.as(byteStream.transform(dart.as(this.decoder, async.StreamTran sformer$(core.List$(core.int), dynamic))).fold(new core.StringBuffer(), (buffer, string) => dart.dinvoke(buffer, 'write', string), buffer).then((buffer) => buff er.toString()), async.Future$(core.String));
34 } 34 }
35 static getByName(name) { 35 static getByName(name) {
36 if (name == null) 36 if (name == null)
37 return null; 37 return null;
38 name = name.toLowerCase(); 38 name = name.toLowerCase();
39 return Encoding[_nameToEncoding].get(name); 39 return Encoding[_nameToEncoding].get(name);
40 } 40 }
41 } 41 }
42 dart.defineLazyProperties(Encoding, { 42 dart.defineLazyProperties(Encoding, {
43 get _nameToEncoding() { 43 get _nameToEncoding() {
(...skipping 1474 matching lines...) Expand 10 before | Expand all | Expand 10 after
1518 writeAll(objects, separator) { 1518 writeAll(objects, separator) {
1519 if (separator === void 0) 1519 if (separator === void 0)
1520 separator = ""; 1520 separator = "";
1521 if (this[_buffer].isNotEmpty) 1521 if (this[_buffer].isNotEmpty)
1522 this[_flush](); 1522 this[_flush]();
1523 let iterator = objects.iterator; 1523 let iterator = objects.iterator;
1524 if (!dart.notNull(iterator.moveNext())) 1524 if (!dart.notNull(iterator.moveNext()))
1525 return; 1525 return;
1526 if (separator.isEmpty) { 1526 if (separator.isEmpty) {
1527 do { 1527 do {
1528 this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toStrin g'), core.String)); 1528 this[_chunkedSink].add(dart.as(iterator.current.toString(), core.Strin g));
1529 } while (iterator.moveNext()); 1529 } while (iterator.moveNext());
1530 } else { 1530 } else {
1531 this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toString' ), core.String)); 1531 this[_chunkedSink].add(dart.as(iterator.current.toString(), core.String) );
1532 while (iterator.moveNext()) { 1532 while (iterator.moveNext()) {
1533 this.write(separator); 1533 this.write(separator);
1534 this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toStrin g'), core.String)); 1534 this[_chunkedSink].add(dart.as(iterator.current.toString(), core.Strin g));
1535 } 1535 }
1536 } 1536 }
1537 } 1537 }
1538 [_flush]() { 1538 [_flush]() {
1539 let accumulated = this[_buffer].toString(); 1539 let accumulated = this[_buffer].toString();
1540 this[_buffer].clear(); 1540 this[_buffer].clear();
1541 this[_chunkedSink].add(accumulated); 1541 this[_chunkedSink].add(accumulated);
1542 } 1542 }
1543 } 1543 }
1544 _StringConversionSinkAsStringSinkAdapter[dart.implements] = () => [ClosableStr ingSink]; 1544 _StringConversionSinkAsStringSinkAdapter[dart.implements] = () => [ClosableStr ingSink];
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
2362 exports.LineSplitter = LineSplitter; 2362 exports.LineSplitter = LineSplitter;
2363 exports.StringConversionSink = StringConversionSink; 2363 exports.StringConversionSink = StringConversionSink;
2364 exports.ClosableStringSink = ClosableStringSink; 2364 exports.ClosableStringSink = ClosableStringSink;
2365 exports.UNICODE_REPLACEMENT_CHARACTER_RUNE = UNICODE_REPLACEMENT_CHARACTER_RUN E; 2365 exports.UNICODE_REPLACEMENT_CHARACTER_RUNE = UNICODE_REPLACEMENT_CHARACTER_RUN E;
2366 exports.UNICODE_BOM_CHARACTER_RUNE = UNICODE_BOM_CHARACTER_RUNE; 2366 exports.UNICODE_BOM_CHARACTER_RUNE = UNICODE_BOM_CHARACTER_RUNE;
2367 exports.UTF8 = UTF8; 2367 exports.UTF8 = UTF8;
2368 exports.Utf8Codec = Utf8Codec; 2368 exports.Utf8Codec = Utf8Codec;
2369 exports.Utf8Encoder = Utf8Encoder; 2369 exports.Utf8Encoder = Utf8Encoder;
2370 exports.Utf8Decoder = Utf8Decoder; 2370 exports.Utf8Decoder = Utf8Decoder;
2371 })(convert || (convert = {})); 2371 })(convert || (convert = {}));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698