Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: ui/views/bubble/bubble_delegate.cc

Issue 1055883002: Fire an alert event to notify accessibility when a permissions bubble gets shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not condition upon presence of anchor. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index 55ce980289149c322219d60e35222009d4ee8614..1dd8817a0e1038ad67ed1aaee8c406b6a36b5ef6 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -300,11 +300,15 @@ void BubbleDelegateView::UpdateColorsFromTheme(const ui::NativeTheme* theme) {
void BubbleDelegateView::HandleVisibilityChanged(Widget* widget, bool visible) {
if (widget == GetWidget() && anchor_widget() &&
anchor_widget()->GetTopLevelWidget()) {
- if (visible)
+ if (visible) {
msw 2015/04/06 17:57:20 nit: you don't need to add these curly braces anym
David Tseng 2015/04/06 18:03:32 Done.
anchor_widget()->GetTopLevelWidget()->DisableInactiveRendering();
- else
+ } else {
anchor_widget()->GetTopLevelWidget()->EnableInactiveRendering();
+ }
}
+
+ if (widget == GetWidget() && visible)
+ NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
}
} // namespace views
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698