Issue 1055873005: Speculative Revert "ScreenOrientationController to start observing even without an internal display…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055873005: Speculative Revert "ScreenOrientationController to start observing even without an internal display… (Closed)

Created:
5 years, 8 months ago by dharani1

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@2372

Target Ref:
refs/pending/branch-heads/2372

Project:
chromium

Visibility:
Public.

Speculative Revert "ScreenOrientationController to start observing even without an internal display." This reverts commit 31fed68a524d49f99cebf02dca6ad49019e9900c. BUG= Committed: https://chromium.googlesource.com/chromium/src/+/36855109117cd99e1e5faa96b5649f1d672725b1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -31 lines)			Patch
	M	ash/content/display/screen_orientation_controller_chromeos.cc	View		3 chunks	+10 lines, -12 lines	0 comments	Download
	M	ash/content/display/screen_orientation_controller_chromeos_unittest.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download

Total messages: 1 (0 generated)

dharani1

5 years, 8 months ago (2015-04-17 09:36:01 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36855109117cd99e1e5faa96b5649f1d672725b1.