ChromeOS: switch UI language before apps are loaded.

chrome/browser/chromeos/extensions/input_method_event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/input_method_event_router.h"
 
 #include <algorithm>
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/extensions/input_method_api.h"
+#include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_context.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_system.h"
 
 namespace chromeos {
 
 ExtensionInputMethodEventRouter::ExtensionInputMethodEventRouter(
     content::BrowserContext* context)
     : context_(context) {
   input_method::InputMethodManager::Get()->AddObserver(this);
 }
 
 ExtensionInputMethodEventRouter::~ExtensionInputMethodEventRouter() {
   input_method::InputMethodManager::Get()->RemoveObserver(this);
 }
 
 void ExtensionInputMethodEventRouter::InputMethodChanged(
-    input_method::InputMethodManager *manager,
+    input_method::InputMethodManager* manager,
+    Profile* profile,
     bool show_message) {
+  CHECK(static_cast<content::BrowserContext*>(profile) == context_);

[robliao, 2015/05/06 18:20:32]

This will trigger a chrome crash if it fails. How critical is it that the
context matches?

[Alexander Alekseev, 2015/05/07 15:21:57]

Here is crbug.com/483258 - what happens (crash) when message is delivered to a
wrong profile.

[robliao, 2015/05/08 17:30:20]

Add a comment about the use of the CHECK here then as this is serious business.

[Alexander Alekseev, 2015/05/12 17:30:45]

I've replaced CHECK with DCHECK and comment.
I'll submit another CL with CHECK, so that revert would be easier if needed.

   extensions::EventRouter* router = extensions::EventRouter::Get(context_);
 
   if (!router->HasEventListener(
           extensions::InputMethodAPI::kOnInputMethodChanged)) {
     return;
   }
 
   scoped_ptr<base::ListValue> args(new base::ListValue());
   base::StringValue* input_method_name =
       new base::StringValue(extensions::InputMethodAPI::GetInputMethodForXkb(
           manager->GetActiveIMEState()->GetCurrentInputMethod().id()));
   args->Append(input_method_name);
 
   // The router will only send the event to extensions that are listening.
   scoped_ptr<extensions::Event> event(new extensions::Event(
       extensions::InputMethodAPI::kOnInputMethodChanged, args.Pass()));
   event->restrict_to_browser_context = context_;
   router->BroadcastEvent(event.Pass());
 }
 
 }  // namespace chromeos