Swizzler changes Index8 and 565

tests/CodexTest.cpp

Index: tests/CodexTest.cpp
diff --git a/tests/CodexTest.cpp b/tests/CodexTest.cpp
index 26846a4550816371281c0797781a1b90cb31c355..20a9fed2f1a799eb330d78e2dd9dbfac12409335 100644
--- a/tests/CodexTest.cpp
+++ b/tests/CodexTest.cpp
@@ -41,7 +41,7 @@ static void check(skiatest::Reporter* r,
         ERRORF(r, "Unable to decode '%s'", path);
         return;
     }
-    SkImageInfo info = codec->getInfo();
+    SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType);

[msarett, 2015/04/09 16:26:32]

If we don't add this, gif will try to decode to kIndex8, which will fail because
we don't provide a color table.

If it is our goal to use this test to test all possible color type outputs, I
need to go back in and implement something similar to what we have in dm.

If we are simply using this test to check rewinding, then I think this change is
logical.

[scroggo, 2015/04/09 17:37:17]

Another option: we could check for kIndex8, and selectively use a different
color type in that case.
Testing all color type outputs is a slightly trickier, since we'll need to
accept failure for non supported color types.
Agreed. Please add a comment why we only do N32, though.

[msarett, 2015/04/09 19:21:31]

Done.

     REPORTER_ASSERT(r, info.dimensions() == size);
     SkBitmap bm;
     bm.allocPixels(info);
@@ -94,6 +94,11 @@ DEF_TEST(Codec, r) {
     // Decodes an embedded PNG image
     check(r, "google_chrome.ico", SkISize::Make(256, 256), false);
 
+    // GIF
+    check(r, "box.gif", SkISize::Make(200, 55), false);
+    check(r, "color_wheel.gif", SkISize::Make(128, 128), false);
+    check(r, "randPixels.gif", SkISize::Make(8, 8), false);
+
     // PNG
     check(r, "arrow.png", SkISize::Make(187, 312), true);
     check(r, "baby_tux.png", SkISize::Make(240, 246), true);