Swizzler changes Index8 and 565

src/codec/SkSwizzler.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkSwizzler_DEFINED
 #define SkSwizzler_DEFINED
 
@@ skipping 110 matching lines @@
      *  @param dstRowBytes rowBytes for dst.
      *  @param ZeroInitialized Whether dst is zero-initialized. The
                                implementation may choose to skip writing zeroes
      *                         if set to kYes_ZeroInitialized.
      *  @return A new SkSwizzler or NULL on failure.
      */
     static SkSwizzler* CreateSwizzler(SrcConfig, const SkPMColor* ctable,
                                       const SkImageInfo&, void* dst,
                                       size_t dstRowBytes,
                                       SkImageGenerator::ZeroInitialized);
+
+    /**
+     * Fill the remainder of the destination with a single color
+     * @param y            the starting row for the fill
+     * @param input        the value to fill with - may be a color or an index

[scroggo, 2015/04/06 14:55:12]

Maybe expand this comment to explain why it might be a color vs an index, and
when it will be treated as a uint8_t.

[msarett, 2015/04/06 18:10:56]

Done.

+     * @param colorTable   a non-NULL colorTable indicates that the input is an index
+     *                     even if the dst color type is not an index type
+     */
+    static void Fill(void* dst, const SkImageInfo& dstInfo, size_t dstRowBytes, uint32_t y,
+            uint32_t input, SkPMColor* colorTable);

[scroggo, 2015/04/06 14:55:12]

I find it a little surprising that we do not need to know the SrcConfig. I guess
we always convert our colors to 32bit before here (unless it's an index)?

[msarett, 2015/04/06 18:10:56]

Yeah you are right.  It works because we are always expecting kN32 colors for
the destination (unless its an index, indicated by the color table), so we know
that is what will be passed in.

We may need to add srcConfig is we end up adding 565 or something like that
here.

+
     /**
      *  Swizzle the next line. Call height times, once for each row of source.
      *  @param src The next row of the source data.
      *  @return A result code describing if the row was fully opaque, fully
      *          transparent, or neither
      */
     ResultAlpha next(const uint8_t* SK_RESTRICT src);
 
     /**
      *
      * Alternate version of next that allows the caller to specify the row.
      * It is very important to only use one version of next.  Since the other
      * version modifies the dst pointer, it will change the behavior of this
      * function.  We will check this in Debug mode.
      *
      */
     ResultAlpha next(const uint8_t* SK_RESTRICT src, int y);
 
     /**
      *  Update the destination row.
      *
      *  Typically this is done by next, but for a client that wants to manually
      *  modify the destination row (for example, for decoding scanline one at a
      *  time) they can call this before each call to next.
      *  TODO: Maybe replace this with a version of next which allows supplying the
      *  destination?
      */
     void setDstRow(void* dst) { fDstRow = dst; }
+
 private:
 
 #ifdef SK_DEBUG
     /*
      *
      * Keep track of which version of next the caller is using
      *
      */
     enum NextMode {
         kUninitialized_NextMode,
@@ skipping 28 matching lines @@
     const SkImageInfo   fDstInfo;
     void*               fDstRow;
     const size_t        fDstRowBytes;
     int                 fCurrY;
 
     SkSwizzler(RowProc proc, const SkPMColor* ctable, int deltaSrc,
                const SkImageInfo& info, void* dst, size_t rowBytes);
 
 };
 #endif // SkSwizzler_DEFINED