Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1055713002: Fix memory leak in dbus::ObjectManager::RemoveInterface (Closed)

Created:
5 years, 8 months ago by Alex Vakulenko
Modified:
5 years, 8 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in dbus::ObjectManager::RemoveInterface D-Bus Object Manager proxy class was leaking PropertySet object instances stored in properties_map when an interface was removed. Make sure we delete the PropertySet before we remove the map entry. BUG=472654 Committed: https://crrev.com/9a99965adab379a5965484a59334a80bc576e49e Cr-Commit-Position: refs/heads/master@{#323544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dbus/object_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055713002/1
5 years, 8 months ago (2015-04-01 23:57:22 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-01 23:57:24 UTC) #4
Alex Vakulenko
5 years, 8 months ago (2015-04-01 23:57:31 UTC) #6
keybuk
lgtm
5 years, 8 months ago (2015-04-02 17:10:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055713002/1
5 years, 8 months ago (2015-04-02 17:11:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 18:51:43 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:28:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a99965adab379a5965484a59334a80bc576e49e
Cr-Commit-Position: refs/heads/master@{#323544}

Powered by Google App Engine
This is Rietveld 408576698