Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1055703004: Move FilePathWatcher tests to base_unittests. (Closed)

Created:
5 years, 8 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FilePathWatcher tests to base_unittests. A long time ago, they had been moved to browser_tests. This was because of the OS X implementation was flaky and caused hanging tests, and the absence of robust test timeouts in unit tests resulted in the entire test binary hanging. Things have changed significantly meanwhile: The new test launcher provides robust test timeout handling, and the OS X implementation has been fixed. Hence, it's safe to move the test over to base_unittests. BUG=chromium:78722 Committed: https://crrev.com/c2c9bb08b9683a1313f61b64614fa8e1e2c39785 Cr-Commit-Position: refs/heads/master@{#324680}

Patch Set 1 #

Patch Set 2 : Revert accidental changes, exclude Android for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -873 lines) Patch
M base/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
D base/files/file_path_watcher_browsertest.cc View 1 chunk +0 lines, -871 lines 0 comments Download
A + base/files/file_path_watcher_unittest.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Mattias Nissler (ping if slow)
5 years, 8 months ago (2015-04-10 09:42:57 UTC) #2
pauljensen
I'll let you fix the test failures before reviewing.
5 years, 8 months ago (2015-04-10 11:09:20 UTC) #3
Mattias Nissler (ping if slow)
On 2015/04/10 11:09:20, pauljensen wrote: > I'll let you fix the test failures before reviewing. ...
5 years, 8 months ago (2015-04-10 11:24:16 UTC) #4
Mattias Nissler (ping if slow)
OK, I've decide to make one step at a time to simplify things, so this ...
5 years, 8 months ago (2015-04-10 12:06:10 UTC) #5
pauljensen
> Paul, my Android build environment isn't functional right now, so are you cool > ...
5 years, 8 months ago (2015-04-10 13:05:21 UTC) #6
pauljensen
This CL lgtm.
5 years, 8 months ago (2015-04-10 13:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055703004/20001
5 years, 8 months ago (2015-04-10 13:58:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/55461)
5 years, 8 months ago (2015-04-10 14:07:24 UTC) #11
Mattias Nissler (ping if slow)
+thestig@ for OWNERS review
5 years, 8 months ago (2015-04-10 14:15:19 UTC) #13
Lei Zhang
lgtm Woo, finally.
5 years, 8 months ago (2015-04-10 20:36:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055703004/20001
5 years, 8 months ago (2015-04-10 20:37:04 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 21:03:04 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 21:04:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2c9bb08b9683a1313f61b64614fa8e1e2c39785
Cr-Commit-Position: refs/heads/master@{#324680}

Powered by Google App Engine
This is Rietveld 408576698