Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1055703003: Revert of Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" (Closed)

Created:
5 years, 8 months ago by tkent
Modified:
5 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" (patchset #1 id:1 of https://codereview.chromium.org/1034863002/) Reason for revert: Major bugs were fixed. Original issue's description: > Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" (patchset #1 id:1 of https://codereview.chromium.org/1005873006/) > > Reason for revert: > crbug.com/470459, crbug.com/470464, crbug.com/470503, crbug.com/470504, crbug.com/470505 > > Original issue's description: > > Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" > > > > Reason: All known major bugs were fixed. We'd like to try again. > > > > > Revert 191098 "Enable HTMLPopupMenu in stable" > > > > > > Reason: Caused crashes > > > > > > > Enable HTMLPopupMenu in stable > > > > > > > > BUG=346582 > > > > > > > > Review URL: https://codereview.chromium.org/961673005 > > > > > > TBR=keishi@chromium.org > > > > > > Review URL: https://codereview.chromium.org/983373002 > > > > TBR=keishi@chromium.org > > BUG=346582 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192407 > > TBR=keishi@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=346582 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192561 TBR=keishi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192990

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Created Revert of Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable""
5 years, 8 months ago (2015-04-02 03:31:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055703003/1
5 years, 8 months ago (2015-04-02 03:32:26 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/platform/RuntimeEnabledFeatures.in: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 8 months ago (2015-04-02 03:33:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055703003/40001
5 years, 8 months ago (2015-04-02 03:37:05 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 03:38:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192990

Powered by Google App Engine
This is Rietveld 408576698