mojo/public/cpp/bindings/tests/router_unittest.cc - Issue 1055703002: Gather trace data by waiting on handles with a fixed timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/router_unittest.cc

Issue 1055703002: Gather trace data by waiting on handles with a fixed timeout (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: review feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/router_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/router_unittest.cc b/mojo/public/cpp/bindings/tests/router_unittest.cc

index d3d8ccb8eae93327ab55e1a0f2a7f96db69d21c7..def9cebfb69adf035167e259531874047aa2794f 100644

--- a/mojo/public/cpp/bindings/tests/router_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/router_unittest.cc

@@ -195,8 +195,8 @@ TEST_F(RouterTest, BasicRequestResponse_Synchronous) {

internal::MessageQueue message_queue;

router0.AcceptWithResponder(&request, new MessageAccumulator(&message_queue));

- router1.WaitForIncomingMessage();

- router0.WaitForIncomingMessage();

+ router1.WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);

+ router0.WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);

EXPECT_FALSE(message_queue.IsEmpty());

@@ -213,8 +213,8 @@ TEST_F(RouterTest, BasicRequestResponse_Synchronous) {

router0.AcceptWithResponder(&request2,

new MessageAccumulator(&message_queue));

- router1.WaitForIncomingMessage();

- router0.WaitForIncomingMessage();

+ router1.WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);

+ router0.WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);

EXPECT_FALSE(message_queue.IsEmpty());

« no previous file with comments | « mojo/public/cpp/bindings/tests/connector_unittest.cc ('k') | services/tracing/BUILD.gn » ('j') | no next file with comments »