Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: mojo/common/data_pipe_utils.cc

Issue 1055703002: Gather trace data by waiting on handles with a fixed timeout (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/common/trace_controller_impl.cc » ('j') | mojo/public/cpp/bindings/lib/connector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/data_pipe_utils.cc
diff --git a/mojo/common/data_pipe_utils.cc b/mojo/common/data_pipe_utils.cc
index 9174cbb8b5a41cc9cda19150c6cabdfc87749918..60f323069ff6904fe47caa784922892f6ffaad83 100644
--- a/mojo/common/data_pipe_utils.cc
+++ b/mojo/common/data_pipe_utils.cc
@@ -93,6 +93,8 @@ bool MOJO_COMMON_EXPORT BlockingCopyFromString(
char_buffer[byte_index++] = *it++;
}
EndWriteDataRaw(destination.get(), byte_index);
+ if (it == source.end())
viettrungluu 2015/04/02 19:54:12 If we want to keep this function around, we really
+ return true;
} else if (result == MOJO_RESULT_SHOULD_WAIT) {
result = Wait(destination.get(), MOJO_HANDLE_SIGNAL_WRITABLE,
MOJO_DEADLINE_INDEFINITE, nullptr);
« no previous file with comments | « no previous file | mojo/common/trace_controller_impl.cc » ('j') | mojo/public/cpp/bindings/lib/connector.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698