Gather trace data by waiting on handles with a fixed timeout

services/tracing/collector_impl.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_TRACING_COLLECTOR_IMPL_H_
+#define SERVICES_TRACING_COLLECTOR_IMPL_H_
+
+#include "mojo/public/cpp/bindings/binding.h"

[viettrungluu, 2015/04/02 19:54:13]

nit: include "base/macros.h"

+#include "mojo/public/cpp/bindings/string.h"
+#include "services/tracing/trace_data_sink.h"
+#include "services/tracing/tracing.mojom.h"
+
+namespace tracing {
+
+class CollectorImpl : public TraceDataCollector {
+ public:
+  CollectorImpl(mojo::InterfaceRequest<TraceDataCollector> request,
+                TraceDataSink* sink);
+  ~CollectorImpl() override;
+
+  void Read();

[viettrungluu, 2015/04/02 19:54:13]

Could use some comments.

(E.g., what does Read() do and when may it be called?)

RawHandleValue() ... of what?

[jamesr, 2015/04/06 22:31:04]

Renamed to TryRead() and added comment
renamed and commented

+  mojo::Handle RawHandleValue() const;
+
+ private:
+  // tracing::TraceDataCollector implementation.
+  void DataCollected(const mojo::String& json) override;
+
+  TraceDataSink* sink_;
+  mojo::Binding<TraceDataCollector> binding_;
+
+  DISALLOW_COPY_AND_ASSIGN(CollectorImpl);
+};
+
+}  // namespace tracing
+
+#endif  // SERVICES_TRACING_COLLECTOR_IMPL_H_