Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1055683008: Rename variable name from renderText to layoutText (Closed)

Created:
5 years, 8 months ago by h.joshi
Modified:
5 years, 8 months ago
CC:
aboxhall, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, dglazkov+blink, dmazzoni, dshwang, eae+blinkwatch, jchaffraix+rendering, je_julie(Not used), leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, slimming-paint-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename variable name from renderText to layoutText Class name is already changed in https://codereview.chromium.org/940373003, variables still use renderText. Code re-factor only, layout test not needed. Bug=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M Source/core/dom/Range.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 11 chunks +22 lines, -22 lines 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/accessibility/AXInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
h.joshi
Pls review
5 years, 8 months ago (2015-04-16 04:05:25 UTC) #2
Dominik Röttsches
Non-owner LGTM. Please fix the description: One line subject, one line space, description, BUG=<number>.
5 years, 8 months ago (2015-04-16 07:46:52 UTC) #3
h.joshi
@Dominik: Made suggested changes. We do not have any specific bug tracking these changes. In ...
5 years, 8 months ago (2015-04-16 08:52:27 UTC) #5
dsinclair
LGTM. Thanks a lot for doing this. You can use crbug.com/462960 as the tracking bug ...
5 years, 8 months ago (2015-04-16 13:48:23 UTC) #7
h.joshi
@dsinclair/Dominik: Thank you Added Bug number in the description.
5 years, 8 months ago (2015-04-17 04:08:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055683008/1
5 years, 8 months ago (2015-04-17 04:08:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/31483)
5 years, 8 months ago (2015-04-17 04:17:43 UTC) #12
h.joshi
@dmazzoni: Pls review getting following error when trying to land patch. ** Presubmit ERRORS ** ...
5 years, 8 months ago (2015-04-17 04:36:16 UTC) #14
dmazzoni
lgtm
5 years, 8 months ago (2015-04-17 06:29:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055683008/1
5 years, 8 months ago (2015-04-17 06:30:08 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 06:33:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193924

Powered by Google App Engine
This is Rietveld 408576698