Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: extensions/common/api/runtime.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/runtime.json
diff --git a/extensions/common/api/runtime.json b/extensions/common/api/runtime.json
index de6e5960d681c700b5b0029339fb96581d525cae..3baa753850e5ec232f03b0028932b2df5f5eb049 100644
--- a/extensions/common/api/runtime.json
+++ b/extensions/common/api/runtime.json
@@ -44,26 +44,59 @@
}
},
{
+ "id": "PlatformInfoOs",
not at google - send to devlin 2015/04/03 17:04:38 Likewise, might as well leave out the "Info" here.
Devlin 2015/04/03 19:38:51 Done.
+ "type": "string",
+ "description": "The operating system chrome is running on.",
+ "enum": ["mac", "win", "android", "cros", "linux", "openbsd"]
+ },
+ {
+ "id": "PlatformInfoArch",
+ "type": "string",
+ "enum": ["arm", "x86-32", "x86-64"],
+ "description": "The machine's processor architecture."
+ },
+ {
+ "id": "PlatformInfoNaclArch",
+ "description": "The native client architecture. This may be different from arch on some platforms.",
+ "type": "string",
+ "enum": ["arm", "x86-32", "x86-64"]
+ },
+ {
"id": "PlatformInfo",
"type": "object",
"description": "An object containing information about the current platform.",
"properties": {
"os": {
- "type": "string",
- "description": "The operating system chrome is running on.",
- "enum": ["mac", "win", "android", "cros", "linux", "openbsd"]
+ "$ref": "PlatformInfoOs",
+ "description": "The operating system chrome is running on."
},
"arch": {
- "type": "string",
- "enum": ["arm", "x86-32", "x86-64"],
+ "$ref": "PlatformInfoArch",
"description": "The machine's processor architecture."
},
"nacl_arch" : {
"description": "The native client architecture. This may be different from arch on some platforms.",
- "type": "string",
- "enum": ["arm", "x86-32", "x86-64"]
+ "$ref": "PlatformInfoNaclArch"
}
}
+ },
+ {
+ "id": "RequestUpdateCheckStatus",
+ "type": "string",
+ "enum": ["throttled", "no_update", "update_available"],
+ "description": "Result of the update check."
+ },
+ {
+ "id": "OnInstalledReason",
+ "type": "string",
+ "enum": ["install", "update", "chrome_update", "shared_module_update"],
+ "description": "The reason that this event is being dispatched."
+ },
+ {
+ "id": "OnRestartRequiredReason",
+ "type": "string",
+ "description": "The reason that the event is being dispatched. 'app_update' is used when the restart is needed because the application is updated to a newer version. 'os_update' is used when the restart is needed because the browser/OS is updated to a newer version. 'periodic' is used when the system runs for more than the permitted uptime set in the enterprise policy.",
+ "enum": ["app_update", "os_update", "periodic"]
}
],
"properties": {
@@ -178,8 +211,7 @@
"parameters": [
{
"name": "status",
- "type": "string",
- "enum": ["throttled", "no_update", "update_available"],
+ "$ref": "RequestUpdateCheckStatus",
"description": "Result of the update check."
},
{
@@ -364,8 +396,7 @@
"name": "details",
"properties": {
"reason": {
- "type": "string",
- "enum": ["install", "update", "chrome_update", "shared_module_update"],
+ "$ref": "OnInstalledReason",
"description": "The reason that this event is being dispatched."
},
"previousVersion": {
@@ -482,10 +513,9 @@
"description": "Fired when an app or the device that it runs on needs to be restarted. The app should close all its windows at its earliest convenient time to let the restart to happen. If the app does nothing, a restart will be enforced after a 24-hour grace period has passed. Currently, this event is only fired for Chrome OS kiosk apps.",
"parameters": [
{
- "type": "string",
+ "$ref": "OnRestartRequiredReason",
"name": "reason",
- "description": "The reason that the event is being dispatched. 'app_update' is used when the restart is needed because the application is updated to a newer version. 'os_update' is used when the restart is needed because the browser/OS is updated to a newer version. 'periodic' is used when the system runs for more than the permitted uptime set in the enterprise policy.",
- "enum": ["app_update", "os_update", "periodic"]
+ "description": "The reason that the event is being dispatched."
}
]
}

Powered by Google App Engine
This is Rietveld 408576698