Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: extensions/common/api/web_view_internal.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/web_request_internal.json ('k') | extensions/renderer/resources/binding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/web_view_internal.json
diff --git a/extensions/common/api/web_view_internal.json b/extensions/common/api/web_view_internal.json
index c81940800fb8bd72060a1ba010a54b8e201ce777..671808929055c8d419cd8f2fe266f086dcd21f96 100644
--- a/extensions/common/api/web_view_internal.json
+++ b/extensions/common/api/web_view_internal.json
@@ -82,6 +82,17 @@
"description": "Disables all zooming in the webview. The content will revert to the default zoom level, and all attempted zoom changes will be ignored."
}
]
+ },
+ {
+ "id": "StopFindingAction",
+ "type": "string",
+ "description": "Determines what to do with the active match after the find session has ended. 'clear' will clear the highlighting over the active match; 'keep' will keep the active match highlighted; 'activate' will keep the active match highlighted and simulate a user click on that match.",
+ "enum": ["clear", "keep", "activate"]
+ },
+ {
+ "id": "SetPermissionAction",
+ "type": "string",
+ "enum": ["allow", "deny", "default"]
}
],
"functions": [
@@ -335,11 +346,10 @@
"description": "The instance ID of the guest <webview> process."
},
{
- "type": "string",
+ "$ref": "StopFindingAction",
"name": "action",
- "description": "Determines what to do with the active match after the find session has ended. 'clear' will clear the highlighting over the active match; 'keep' will keep the active match highlighted; 'activate' will keep the active match highlighted and simulate a user click on that match.",
- "optional": true,
- "enum": ["clear", "keep", "activate"]
+ "description": "Determines what to do with the active match after the find session has ended.",
+ "optional": true
}
]
},
@@ -482,9 +492,8 @@
"name": "requestId"
},
{
- "type": "string",
- "name": "action",
- "enum": ["allow", "deny", "default"]
+ "$ref": "SetPermissionAction",
+ "name": "action"
},
{
"type": "string",
« no previous file with comments | « extensions/common/api/web_request_internal.json ('k') | extensions/renderer/resources/binding.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698