Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Unified Diff: extensions/common/api/management.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/idle.json ('k') | extensions/common/api/runtime.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/management.json
diff --git a/extensions/common/api/management.json b/extensions/common/api/management.json
index 42976387c939b4d0c86f8fb02e77b5e588736982..93f1f1faa570375cb2d57e5daf542d0719c2e8f7 100644
--- a/extensions/common/api/management.json
+++ b/extensions/common/api/management.json
@@ -23,6 +23,24 @@
"description": "These are all possible app launch types."
},
{
+ "id": "ExtensionDisabledReason",
+ "description": "A reason the item is disabled.",
+ "type": "string",
+ "enum": ["unknown", "permissions_increase"]
+ },
+ {
+ "id": "ExtensionType",
+ "description": "The type of this extension, app, or theme.",
+ "type": "string",
+ "enum": ["extension", "hosted_app", "packaged_app", "legacy_packaged_app", "theme"]
+ },
+ {
+ "id": "ExtensionInstallType",
+ "description": "How the extension was installed. One of<br><var>admin</var>: The extension was installed because of an administrative policy,<br><var>development</var>: The extension was loaded unpacked in developer mode,<br><var>normal</var>: The extension was installed normally via a .crx file,<br><var>sideload</var>: The extension was installed by other software on the machine,<br><var>other</var>: The extension was installed by other means.",
+ "type": "string",
+ "enum": ["admin", "development", "normal", "sideload", "other"]
+ },
+ {
"id": "ExtensionInfo",
"description": "Information about an installed extension, app, or theme.",
"type": "object",
@@ -57,8 +75,7 @@
},
"disabledReason": {
"description": "A reason the item is disabled.",
- "type": "string",
- "enum": ["unknown", "permissions_increase"],
+ "$ref": "ExtensionDisabledReason",
"optional": true
},
"isApp": {
@@ -68,8 +85,7 @@
},
"type": {
"description": "The type of this extension, app, or theme.",
- "type": "string",
- "enum": ["extension", "hosted_app", "packaged_app", "legacy_packaged_app", "theme"]
+ "$ref": "ExtensionType"
},
"appLaunchUrl": {
"description": "The launch url (only present for apps).",
@@ -117,9 +133,8 @@
}
},
"installType": {
- "description": "How the extension was installed. One of<br><var>admin</var>: The extension was installed because of an administrative policy,<br><var>development</var>: The extension was loaded unpacked in developer mode,<br><var>normal</var>: The extension was installed normally via a .crx file,<br><var>sideload</var>: The extension was installed by other software on the machine,<br><var>other</var>: The extension was installed by other means.",
- "type": "string",
- "enum": ["admin", "development", "normal", "sideload", "other"]
+ "description": "How the extension was installed.",
+ "$ref": "ExtensionInstallType"
},
"launchType": {
"description": "The app launch type (only present for apps).",
« no previous file with comments | « extensions/common/api/idle.json ('k') | extensions/common/api/runtime.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698