extensions/browser/api/capture_web_contents_function.h - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/capture_web_contents_function.h

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/capture_web_contents_function.h

diff --git a/extensions/browser/api/capture_web_contents_function.h b/extensions/browser/api/capture_web_contents_function.h

index 9f60234104d0db2760f335efb7778d6de2212586..37100a9ff3685d7654192f0435040f2ffe197f30 100644

--- a/extensions/browser/api/capture_web_contents_function.h

+++ b/extensions/browser/api/capture_web_contents_function.h

@@ -41,7 +41,6 @@ class CaptureWebContentsFunction : public AsyncExtensionFunction {

virtual void OnCaptureFailure(FailureReason reason) = 0;

private:

- typedef core_api::extension_types::ImageDetails ImageDetails;

void CopyFromBackingStoreComplete(const SkBitmap& bitmap,

content::ReadbackResponse response);

@@ -54,7 +53,7 @@ class CaptureWebContentsFunction : public AsyncExtensionFunction {

int context_id_;

// The format (JPEG vs PNG) of the resulting image. Set in RunAsync().

- ImageDetails::Format image_format_;

+ core_api::extension_types::ImageFormat image_format_;

// Quality setting to use when encoding jpegs. Set in RunAsync().

int image_quality_;