Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1781)

Unified Diff: chrome/common/extensions/api/omnibox.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/metrics_private.json ('k') | chrome/common/extensions/api/system_private.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/omnibox.json
diff --git a/chrome/common/extensions/api/omnibox.json b/chrome/common/extensions/api/omnibox.json
index 9d552e5c88b5b876887ec2fa6d8815ed56f3d1c6..614f5ec6f080d2f0d4a46405ce0c6fe9ed56aada 100644
--- a/chrome/common/extensions/api/omnibox.json
+++ b/chrome/common/extensions/api/omnibox.json
@@ -8,6 +8,18 @@
"description": "The omnibox API allows you to register a keyword with Google Chrome's address bar, which is also known as the omnibox.",
"types": [
{
+ "id": "DescriptionStyleType",
+ "type": "string",
+ "description": "The style type.",
+ "enum": ["url", "match", "dim"]
+ },
+ {
+ "id": "OnInputEnteredDisposition",
+ "type": "string",
+ "enum": ["currentTab", "newForegroundTab", "newBackgroundTab"],
+ "description": "The window disposition for the omnibox query. This is the recommended context to display results. For example, if the omnibox command is to navigate to a certain URL, a disposition of 'newForegroundTab' means the navigation should take place in a new selected tab."
+ },
+ {
"id": "SuggestResult",
"type": "object",
"description": "A suggest result.",
@@ -33,7 +45,7 @@
"description": "The style ranges for the description, as provided by the extension.",
"properties": {
"offset": { "type": "integer" },
- "type": { "description": "The style type", "type": "string", "enum": ["url", "match", "dim"]},
+ "type": { "description": "The style type", "$ref": "DescriptionStyleType"},
"length": { "type": "integer", "optional": true }
}
}
@@ -77,7 +89,7 @@
"description": "The style ranges for the description, as provided by the extension.",
"properties": {
"offset": { "type": "integer" },
- "type": { "description": "The style type", "type": "string", "enum": ["url", "match", "dim"]},
+ "type": { "description": "The style type", "$ref": "DescriptionStyleType"},
"length": { "type": "integer", "optional": true }
}
}
@@ -175,9 +187,7 @@
},
{
"name": "disposition",
- "type": "string",
- "enum": ["currentTab", "newForegroundTab", "newBackgroundTab"],
- "description": "The window disposition for the omnibox query. This is the recommended context to display results. For example, if the omnibox command is to navigate to a certain URL, a disposition of 'newForegroundTab' means the navigation should take place in a new selected tab."
+ "$ref": "OnInputEnteredDisposition"
}
]
},
« no previous file with comments | « chrome/common/extensions/api/metrics_private.json ('k') | chrome/common/extensions/api/system_private.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698