Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5798)

Unified Diff: chrome/common/extensions/api/metrics_private.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/input_ime.json ('k') | chrome/common/extensions/api/omnibox.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/metrics_private.json
diff --git a/chrome/common/extensions/api/metrics_private.json b/chrome/common/extensions/api/metrics_private.json
index 0778440b325db5d3db0fe4f05d3e38bd98c278f1..ba8cc901228c1951e37aa5755ac61b1293c9258a 100644
--- a/chrome/common/extensions/api/metrics_private.json
+++ b/chrome/common/extensions/api/metrics_private.json
@@ -8,15 +8,19 @@
"description": "none",
"types": [
{
+ "id": "MetricTypeType",
+ "type": "string",
+ "enum": ["histogram-log", "histogram-linear"],
+ "description": "The type of metric, such as 'histogram-log' or 'histogram-linear'."
+ },
+ {
"id": "MetricType",
"type": "object",
"description": "Describes the type of metric that is to be collected.",
"properties": {
"metricName": {"type": "string", "description": "A unique name within the extension for the metric."},
"type": {
- "type": "string",
- "enum": ["histogram-log", "histogram-linear"],
- "description": "The type of metric, such as 'histogram-log' or 'histogram-linear'."
+ "$ref": "MetricTypeType"
},
"min": {"type": "integer", "description": "The minimum sample value to be recoded. Must be greater than zero."},
"max": {"type": "integer", "description": "The maximum sample value to be recoded."},
« no previous file with comments | « chrome/common/extensions/api/input_ime.json ('k') | chrome/common/extensions/api/omnibox.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698