Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
diff --git a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
index 865792cee8d70b2e21f53563b8ad01146d3ea0a8..1d2c821752d64443b2a2aa2521fe6924080465d8 100644
--- a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
+++ b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
@@ -23,7 +23,7 @@
#include "ui/keyboard/keyboard_switches.h"
#include "ui/keyboard/keyboard_util.h"
-namespace SetMode = extensions::core_api::virtual_keyboard_private::SetMode;
+namespace keyboard_api = extensions::core_api::virtual_keyboard_private;
namespace {
@@ -37,13 +37,13 @@ std::string GenerateFeatureFlag(std::string feature, bool enabled) {
return feature + (enabled ? "-enabled" : "-disabled");
}
-keyboard::KeyboardMode getKeyboardModeEnum(SetMode::Params::Mode mode) {
+keyboard::KeyboardMode getKeyboardModeEnum(keyboard_api::KeyboardMode mode) {
switch (mode) {
- case SetMode::Params::MODE_NONE:
+ case keyboard_api::KEYBOARD_MODE_NONE:
return keyboard::NONE;
- case SetMode::Params::MODE_FULL_WIDTH:
+ case keyboard_api::KEYBOARD_MODE_FULL_WIDTH:
return keyboard::FULL_WIDTH;
- case SetMode::Params::MODE_FLOATING:
+ case keyboard_api::KEYBOARD_MODE_FLOATING:
return keyboard::FLOATING;
}
return keyboard::NONE;
@@ -152,7 +152,7 @@ bool ChromeVirtualKeyboardDelegate::ShowLanguageSettings() {
bool ChromeVirtualKeyboardDelegate::SetVirtualKeyboardMode(int mode_enum) {
keyboard::KeyboardMode keyboard_mode =
- getKeyboardModeEnum(static_cast<SetMode::Params::Mode>(mode_enum));
+ getKeyboardModeEnum(static_cast<keyboard_api::KeyboardMode>(mode_enum));
keyboard::KeyboardController* controller =
keyboard::KeyboardController::GetInstance();
if (!controller)
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698